liquid_feedback_core

diff lf_update_suggestion_order.c @ 378:e88d0606891f

find changesets by author, revision, files, or words in the commit message
Bugfix regarding "proportional_order" of suggestions:
Use NULL values explicitly to be sorted last
(includes new suggestions as well as suggestions without any individual rankings)
author jbe
date Mon Mar 18 09:36:21 2013 +0100 (2013-03-18)
parents f65814f4d3fc
children eda636259846
line diff
     1.1 --- a/lf_update_suggestion_order.c	Mon Mar 18 09:24:51 2013 +0100
     1.2 +++ b/lf_update_suggestion_order.c	Mon Mar 18 09:36:21 2013 +0100
     1.3 @@ -188,12 +188,12 @@
     1.4    char *cmd;
     1.5    int i;
     1.6    if (final) {
     1.7 -    if (asprintf(&cmd, "BEGIN; UPDATE \"initiative\" SET \"final_suggestion_order_calculated\" = TRUE WHERE \"id\" = %s; UPDATE \"suggestion\" SET \"proportional_order\" = 0 WHERE \"initiative_id\" = %s", escaped_initiative_id, escaped_initiative_id) < 0) {
     1.8 +    if (asprintf(&cmd, "BEGIN; UPDATE \"initiative\" SET \"final_suggestion_order_calculated\" = TRUE WHERE \"id\" = %s; UPDATE \"suggestion\" SET \"proportional_order\" = NULL WHERE \"initiative_id\" = %s", escaped_initiative_id, escaped_initiative_id) < 0) {
     1.9        fprintf(stderr, "Could not prepare query string in memory.\n");
    1.10        abort();
    1.11      }
    1.12    } else {
    1.13 -    if (asprintf(&cmd, "BEGIN; UPDATE \"suggestion\" SET \"proportional_order\" = 0 WHERE \"initiative_id\" = %s", escaped_initiative_id) < 0) {
    1.14 +    if (asprintf(&cmd, "BEGIN; UPDATE \"suggestion\" SET \"proportional_order\" = NULL WHERE \"initiative_id\" = %s", escaped_initiative_id) < 0) {
    1.15        fprintf(stderr, "Could not prepare query string in memory.\n");
    1.16        abort();
    1.17      }

Impressum / About Us