# HG changeset patch # User jbe # Date 1266761025 -3600 # Node ID 3ccab7349f2817763a8bf489df56d3be9dc371e4 # Parent 6d634325a604bf27aad71830e7e0acda6ccbb9c6 Bug in "forbid_changes_on_closed_issue_trigger"() fixed, which caused errors when closing issues under certain circumstances diff -r 6d634325a604 -r 3ccab7349f28 core.sql --- a/core.sql Sat Feb 20 15:09:32 2010 +0100 +++ b/core.sql Sun Feb 21 15:03:45 2010 +0100 @@ -6,7 +6,7 @@ BEGIN; CREATE VIEW "liquid_feedback_version" AS - SELECT * FROM (VALUES ('beta20', NULL, NULL, NULL)) + SELECT * FROM (VALUES ('beta21', NULL, NULL, NULL)) AS "subquery"("string", "major", "minor", "revision"); @@ -990,10 +990,16 @@ RETURNS TRIGGER LANGUAGE 'plpgsql' VOLATILE AS $$ DECLARE - "issue_row" "issue"%ROWTYPE; + "issue_id_v" "issue"."id"%TYPE; + "issue_row" "issue"%ROWTYPE; BEGIN + IF TG_OP = 'DELETE' THEN + "issue_id_v" := OLD."issue_id"; + ELSE + "issue_id_v" := NEW."issue_id"; + END IF; SELECT INTO "issue_row" * FROM "issue" - WHERE "id" = NEW."issue_id" FOR SHARE; + WHERE "id" = "issue_id_v" FOR SHARE; IF "issue_row"."closed" NOTNULL THEN RAISE EXCEPTION 'Tried to modify data belonging to a closed issue.'; END IF;