liquid_feedback_frontend
annotate app/main/contact/_action/add_member.lua @ 75:733f65c0c0a0
Bugfixes, feature enhancements, code-cleanup, and major work on API
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
| author | bsw |
|---|---|
| date | Thu Jul 08 18:44:02 2010 +0200 (2010-07-08) |
| parents | afd9f769c7ae |
| children |
| rev | line source |
|---|---|
| bsw/jbe@0 | 1 local member = app.session.member |
| bsw/jbe@0 | 2 local other_member = Member:by_id(param.get_id()) |
| bsw/jbe@0 | 3 |
| bsw/jbe@0 | 4 local public = param.get("public", atom.boolean) |
| bsw/jbe@0 | 5 |
| bsw/jbe@0 | 6 local contact = Contact:by_pk(member.id, other_member.id) |
| bsw/jbe@0 | 7 |
| bsw/jbe@0 | 8 if public == nil and contact then |
| bsw/jbe@0 | 9 slot.put_into("error", _"Member is already saved in your contacts!") |
| bsw/jbe@0 | 10 return false |
| bsw/jbe@0 | 11 end |
| bsw/jbe@0 | 12 |
| bsw/jbe@0 | 13 if contact then |
| bsw/jbe@0 | 14 contact:destroy() |
| bsw/jbe@0 | 15 end |
| bsw/jbe@0 | 16 |
| bsw/jbe@0 | 17 contact = Contact:new() |
| bsw/jbe@0 | 18 contact.member_id = member.id |
| bsw/jbe@0 | 19 contact.other_member_id = other_member.id |
| bsw/jbe@0 | 20 contact.public = public or false |
| bsw/jbe@0 | 21 contact:save() |
| bsw/jbe@0 | 22 |