liquid_feedback_frontend
annotate app/main/delegation/_action/update.lua @ 75:733f65c0c0a0
Bugfixes, feature enhancements, code-cleanup, and major work on API
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
| author | bsw |
|---|---|
| date | Thu Jul 08 18:44:02 2010 +0200 (2010-07-08) |
| parents | afd9f769c7ae |
| children | 02aacb3dffe0 |
| rev | line source |
|---|---|
| bsw/jbe@0 | 1 local truster_id = app.session.member.id |
| bsw/jbe@0 | 2 |
| bsw/jbe@0 | 3 local trustee_id = param.get("trustee_id", atom.integer) |
| bsw/jbe@0 | 4 |
| bsw/jbe@0 | 5 local area_id = param.get("area_id", atom.integer) |
| bsw/jbe@0 | 6 |
| bsw/jbe@0 | 7 local issue_id = param.get("issue_id", atom.integer) |
| bsw/jbe@0 | 8 |
| bsw/jbe@0 | 9 if issue_id then |
| bsw/jbe@0 | 10 area_id = nil |
| bsw/jbe@0 | 11 end |
| bsw/jbe@0 | 12 |
| bsw/jbe@0 | 13 local delegation = Delegation:by_pk(truster_id, area_id, issue_id) |
| bsw/jbe@0 | 14 |
| bsw/jbe@4 | 15 if param.get("delete") or trustee_id == -1 then |
| bsw/jbe@0 | 16 |
| bsw/jbe@0 | 17 if delegation then |
| bsw/jbe@5 | 18 |
| bsw/jbe@0 | 19 delegation:destroy() |
| bsw/jbe@5 | 20 |
| bsw/jbe@0 | 21 if issue_id then |
| bsw/jbe@0 | 22 slot.put_into("notice", _"Your delegation for this issue has been deleted.") |
| bsw/jbe@0 | 23 elseif area_id then |
| bsw/jbe@0 | 24 slot.put_into("notice", _"Your delegation for this area has been deleted.") |
| bsw/jbe@0 | 25 else |
| bsw/jbe@0 | 26 slot.put_into("notice", _"Your global delegation has been deleted.") |
| bsw/jbe@0 | 27 end |
| bsw/jbe@0 | 28 |
| bsw/jbe@0 | 29 end |
| bsw/jbe@5 | 30 |
| bsw/jbe@0 | 31 else |
| bsw/jbe@0 | 32 |
| bsw/jbe@0 | 33 if not delegation then |
| bsw/jbe@0 | 34 delegation = Delegation:new() |
| bsw/jbe@0 | 35 delegation.truster_id = truster_id |
| bsw/jbe@0 | 36 delegation.area_id = area_id |
| bsw/jbe@0 | 37 delegation.issue_id = issue_id |
| bsw/jbe@5 | 38 if issue_id then |
| bsw/jbe@5 | 39 delegation.scope = "issue" |
| bsw/jbe@5 | 40 elseif area_id then |
| bsw/jbe@5 | 41 delegation.scope = "area" |
| bsw/jbe@5 | 42 else |
| bsw/jbe@5 | 43 delegation.scope = "global" |
| bsw/jbe@5 | 44 end |
| bsw/jbe@0 | 45 end |
| bsw/jbe@0 | 46 |
| bsw/jbe@0 | 47 delegation.trustee_id = trustee_id |
| bsw/jbe@0 | 48 |
| bsw/jbe@0 | 49 delegation:save() |
| bsw/jbe@0 | 50 |
| bsw/jbe@0 | 51 if issue_id then |
| bsw/jbe@0 | 52 slot.put_into("notice", _"Your delegation for this issue has been updated.") |
| bsw/jbe@0 | 53 elseif area_id then |
| bsw/jbe@0 | 54 slot.put_into("notice", _"Your delegation for this area has been updated.") |
| bsw/jbe@0 | 55 else |
| bsw/jbe@0 | 56 slot.put_into("notice", _"Your global delegation has been updated.") |
| bsw/jbe@0 | 57 end |
| bsw/jbe@0 | 58 |
| bsw/jbe@0 | 59 end |
| bsw/jbe@0 | 60 |