liquid_feedback_frontend
annotate app/main/draft/_action/add.lua @ 75:733f65c0c0a0
Bugfixes, feature enhancements, code-cleanup, and major work on API
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
author | bsw |
---|---|
date | Thu Jul 08 18:44:02 2010 +0200 (2010-07-08) |
parents | 72c5e0ee7c98 |
children | 134fce4bede3 |
rev | line source |
---|---|
bsw/jbe@5 | 1 local tmp = db:query({ "SELECT text_entries_left FROM member_contingent_left WHERE member_id = ?", app.session.member.id }, "opt_object") |
bsw/jbe@5 | 2 if tmp and tmp.text_entries_left and tmp.text_entries_left < 1 then |
bsw/jbe@5 | 3 slot.put_into("error", _"Sorry, you have reached your personal flood limit. Please be slower...") |
bsw/jbe@5 | 4 return false |
bsw/jbe@5 | 5 end |
bsw/jbe@5 | 6 |
bsw/jbe@0 | 7 local initiative = Initiative:by_id(param.get("initiative_id", atom.integer)) |
bsw/jbe@0 | 8 |
bsw/jbe@5 | 9 -- TODO important m1 selectors returning result _SET_! |
bsw/jbe@5 | 10 local issue = initiative:get_reference_selector("issue"):for_share():single_object_mode():exec() |
bsw/jbe@5 | 11 |
bsw/jbe@5 | 12 if issue.closed then |
bsw/jbe@5 | 13 slot.put_into("error", _"This issue is already closed.") |
bsw/jbe@5 | 14 return false |
bsw/jbe@5 | 15 elseif issue.half_frozen then |
bsw/jbe@5 | 16 slot.put_into("error", _"This issue is already frozen.") |
bsw/jbe@5 | 17 return false |
bsw/jbe@5 | 18 end |
bsw/jbe@5 | 19 |
bsw@10 | 20 local initiator = Initiator:by_pk(initiative.id, app.session.member.id) |
bsw@10 | 21 if not initiator or not initiator.accepted then |
bsw@10 | 22 error("access denied") |
bsw@10 | 23 end |
bsw@10 | 24 |
bsw@10 | 25 local draft = Draft:new() |
bsw@10 | 26 draft.author_id = app.session.member.id |
bsw@10 | 27 draft.initiative_id = initiative.id |
bsw@10 | 28 local formatting_engine = param.get("formatting_engine") |
bsw@10 | 29 local formatting_engine_valid = false |
bsw@10 | 30 for fe, dummy in pairs(config.formatting_engine_executeables) do |
bsw@10 | 31 if formatting_engine == fe then |
bsw@10 | 32 formatting_engine_valid = true |
bsw/jbe@4 | 33 end |
bsw@10 | 34 end |
bsw@10 | 35 if not formatting_engine_valid then |
bsw@10 | 36 error("invalid formatting engine!") |
bsw@10 | 37 end |
bsw@10 | 38 draft.formatting_engine = formatting_engine |
bsw@10 | 39 draft.content = param.get("content") |
bsw@10 | 40 draft:save() |
bsw/jbe@0 | 41 |
bsw@10 | 42 slot.put_into("notice", _"New draft has been added to initiative") |
bsw/jbe@0 | 43 |