liquid_feedback_frontend
annotate app/main/initiative/_action/add_support.lua @ 75:733f65c0c0a0
Bugfixes, feature enhancements, code-cleanup, and major work on API
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
| author | bsw |
|---|---|
| date | Thu Jul 08 18:44:02 2010 +0200 (2010-07-08) |
| parents | 72c5e0ee7c98 |
| children | 034f96181e59 |
| rev | line source |
|---|---|
| bsw/jbe@0 | 1 local initiative = Initiative:new_selector():add_where{ "id = ?", param.get_id()}:single_object_mode():exec() |
| bsw/jbe@0 | 2 |
| bsw/jbe@5 | 3 -- TODO important m1 selectors returning result _SET_! |
| bsw/jbe@5 | 4 local issue = initiative:get_reference_selector("issue"):for_share():single_object_mode():exec() |
| bsw/jbe@5 | 5 |
| bsw/jbe@5 | 6 if issue.closed then |
| bsw/jbe@5 | 7 slot.put_into("error", _"This issue is already closed.") |
| bsw/jbe@5 | 8 return false |
| bsw/jbe@5 | 9 elseif issue.fully_frozen then |
| bsw/jbe@5 | 10 slot.put_into("error", _"Voting for this issue has already begun.") |
| bsw/jbe@5 | 11 return false |
| bsw/jbe@5 | 12 end |
| bsw/jbe@5 | 13 |
| bsw@10 | 14 if initiative.revoked then |
| bsw@10 | 15 slot.put_into("error", _"This initiative is revoked") |
| bsw@10 | 16 return false |
| bsw@10 | 17 end |
| bsw@10 | 18 |
| bsw/jbe@0 | 19 local member = app.session.member |
| bsw/jbe@0 | 20 |
| bsw/jbe@0 | 21 local supporter = Supporter:by_pk(initiative.id, member.id) |
| bsw/jbe@0 | 22 |
| bsw/jbe@0 | 23 local last_draft = Draft:new_selector() |
| bsw/jbe@0 | 24 :add_where{ "initiative_id = ?", initiative.id } |
| bsw/jbe@0 | 25 :add_order_by("id DESC") |
| bsw/jbe@0 | 26 :limit(1) |
| bsw/jbe@0 | 27 :single_object_mode() |
| bsw/jbe@0 | 28 :exec() |
| bsw/jbe@0 | 29 |
| bsw/jbe@0 | 30 if not supporter then |
| bsw/jbe@0 | 31 supporter = Supporter:new() |
| bsw/jbe@0 | 32 supporter.member_id = member.id |
| bsw/jbe@0 | 33 supporter.initiative_id = initiative.id |
| bsw/jbe@0 | 34 supporter.draft_id = last_draft.id |
| bsw/jbe@0 | 35 supporter:save() |
| bsw/jbe@0 | 36 slot.put_into("notice", _"Your support has been added to this initiative") |
| bsw/jbe@0 | 37 elseif supporter.draft_id ~= last_draft.id then |
| bsw/jbe@0 | 38 supporter.draft_id = last_draft.id |
| bsw/jbe@0 | 39 supporter:save() |
| bsw/jbe@0 | 40 slot.put_into("notice", _"Your support has been updated to the latest draft") |
| bsw/jbe@0 | 41 else |
| bsw/jbe@0 | 42 slot.put_into("notice", _"You are already supporting the latest draft") |
| bsw/jbe@0 | 43 end |