liquid_feedback_frontend
annotate app/main/initiative/_action/create.lua @ 75:733f65c0c0a0
Bugfixes, feature enhancements, code-cleanup, and major work on API
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
| author | bsw |
|---|---|
| date | Thu Jul 08 18:44:02 2010 +0200 (2010-07-08) |
| parents | 3ec1dea6eefb |
| children | 134fce4bede3 |
| rev | line source |
|---|---|
| bsw/jbe@5 | 1 local tmp = db:query({ "SELECT text_entries_left, initiatives_left FROM member_contingent_left WHERE member_id = ?", app.session.member.id }, "opt_object") |
| bsw/jbe@5 | 2 if tmp then |
| bsw/jbe@5 | 3 if tmp.initiatives_left and tmp.initiatives_left < 1 then |
| bsw/jbe@5 | 4 slot.put_into("error", _"Sorry, your contingent for creating initiatives has been used up. Please try again later.") |
| bsw/jbe@5 | 5 return false |
| bsw/jbe@5 | 6 end |
| bsw/jbe@5 | 7 if tmp.text_entries_left and tmp.text_entries_left < 1 then |
| bsw/jbe@5 | 8 slot.put_into("error", _"Sorry, you have reached your personal flood limit. Please be slower...") |
| bsw/jbe@5 | 9 return false |
| bsw/jbe@5 | 10 end |
| bsw/jbe@5 | 11 end |
| bsw/jbe@5 | 12 |
| bsw/jbe@0 | 13 local issue |
| bsw/jbe@0 | 14 local area |
| bsw/jbe@0 | 15 |
| bsw/jbe@0 | 16 local issue_id = param.get("issue_id", atom.integer) |
| bsw/jbe@0 | 17 if issue_id then |
| bsw/jbe@0 | 18 issue = Issue:new_selector():add_where{"id=?",issue_id}:single_object_mode():exec() |
| bsw/jbe@5 | 19 if issue.closed then |
| bsw/jbe@5 | 20 slot.put_into("error", _"This issue is already closed.") |
| bsw/jbe@5 | 21 return false |
| bsw/jbe@5 | 22 elseif issue.fully_frozen then |
| bsw/jbe@5 | 23 slot.put_into("error", _"Voting for this issue has already begun.") |
| bsw/jbe@5 | 24 return false |
| bsw/jbe@5 | 25 end |
| bsw/jbe@0 | 26 area = issue.area |
| bsw/jbe@0 | 27 else |
| bsw/jbe@0 | 28 local area_id = param.get("area_id", atom.integer) |
| bsw/jbe@0 | 29 area = Area:new_selector():add_where{"id=?",area_id}:single_object_mode():exec() |
| bsw/jbe@52 | 30 if not area.active then |
| bsw/jbe@52 | 31 slot.put_into("error", "Invalid area.") |
| bsw/jbe@52 | 32 return false |
| bsw/jbe@52 | 33 end |
| bsw/jbe@0 | 34 end |
| bsw/jbe@0 | 35 |
| bsw@10 | 36 |
| bsw/jbe@52 | 37 |
| bsw/jbe@6 | 38 local name = param.get("name") |
| bsw/jbe@6 | 39 |
| bsw/jbe@6 | 40 local name = util.trim(name) |
| bsw/jbe@6 | 41 |
| bsw/jbe@6 | 42 if #name < 3 then |
| bsw/jbe@6 | 43 slot.put_into("error", _"This name is really too short!") |
| bsw/jbe@6 | 44 return false |
| bsw/jbe@6 | 45 end |
| bsw/jbe@6 | 46 |
| bsw/jbe@0 | 47 local initiative = Initiative:new() |
| bsw/jbe@0 | 48 |
| bsw/jbe@0 | 49 if not issue then |
| bsw@64 | 50 local policy_id = param.get("policy_id", atom.integer) |
| bsw@64 | 51 if policy_id == -1 then |
| bsw@64 | 52 slot.put_into("error", _"Please choose a policy") |
| bsw@64 | 53 return false |
| bsw@64 | 54 end |
| bsw@64 | 55 local policy = Policy:by_id(policy_id) |
| bsw@64 | 56 if not policy.active then |
| bsw@64 | 57 slot.put_into("error", "Invalid policy.") |
| bsw@64 | 58 return false |
| bsw@64 | 59 end |
| bsw@7 | 60 if not area:get_reference_selector("allowed_policies") |
| bsw@7 | 61 :add_where{ "policy.id = ?", policy_id } |
| bsw@7 | 62 :optional_object_mode() |
| bsw@7 | 63 :exec() |
| bsw@7 | 64 then |
| bsw@7 | 65 error("policy not allowed") |
| bsw@7 | 66 end |
| bsw/jbe@0 | 67 issue = Issue:new() |
| bsw/jbe@0 | 68 issue.area_id = area.id |
| bsw@7 | 69 issue.policy_id = policy_id |
| bsw/jbe@0 | 70 issue:save() |
| bsw/jbe@0 | 71 end |
| bsw/jbe@0 | 72 |
| bsw/jbe@0 | 73 initiative.issue_id = issue.id |
| bsw/jbe@6 | 74 initiative.name = name |
| bsw/jbe@6 | 75 param.update(initiative, "discussion_url") |
| bsw/jbe@0 | 76 initiative:save() |
| bsw/jbe@0 | 77 |
| bsw/jbe@0 | 78 local draft = Draft:new() |
| bsw/jbe@0 | 79 draft.initiative_id = initiative.id |
| bsw/jbe@4 | 80 local formatting_engine = param.get("formatting_engine") |
| bsw/jbe@4 | 81 local formatting_engine_valid = false |
| bsw/jbe@4 | 82 for fe, dummy in pairs(config.formatting_engine_executeables) do |
| bsw/jbe@4 | 83 if formatting_engine == fe then |
| bsw/jbe@4 | 84 formatting_engine_valid = true |
| bsw/jbe@4 | 85 end |
| bsw/jbe@4 | 86 end |
| bsw/jbe@4 | 87 if not formatting_engine_valid then |
| bsw/jbe@4 | 88 error("invalid formatting engine!") |
| bsw/jbe@4 | 89 end |
| bsw/jbe@4 | 90 draft.formatting_engine = formatting_engine |
| bsw/jbe@0 | 91 draft.content = param.get("draft") |
| bsw/jbe@0 | 92 draft.author_id = app.session.member.id |
| bsw/jbe@0 | 93 draft:save() |
| bsw/jbe@0 | 94 |
| bsw/jbe@0 | 95 local initiator = Initiator:new() |
| bsw/jbe@0 | 96 initiator.initiative_id = initiative.id |
| bsw/jbe@0 | 97 initiator.member_id = app.session.member.id |
| bsw@10 | 98 initiator.accepted = true |
| bsw/jbe@0 | 99 initiator:save() |
| bsw/jbe@0 | 100 |
| bsw/jbe@0 | 101 local supporter = Supporter:new() |
| bsw/jbe@0 | 102 supporter.initiative_id = initiative.id |
| bsw/jbe@0 | 103 supporter.member_id = app.session.member.id |
| bsw/jbe@0 | 104 supporter.draft_id = draft.id |
| bsw/jbe@0 | 105 supporter:save() |
| bsw/jbe@0 | 106 |
| bsw/jbe@0 | 107 slot.put_into("notice", _"Initiative successfully created") |
| bsw/jbe@0 | 108 |
| bsw/jbe@0 | 109 request.redirect{ |
| bsw/jbe@0 | 110 module = "initiative", |
| bsw/jbe@0 | 111 view = "show", |
| bsw/jbe@0 | 112 id = initiative.id |
| bsw/jbe@0 | 113 } |