liquid_feedback_frontend
annotate app/main/initiative/_action/remove_initiator.lua @ 75:733f65c0c0a0
Bugfixes, feature enhancements, code-cleanup, and major work on API
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
| author | bsw |
|---|---|
| date | Thu Jul 08 18:44:02 2010 +0200 (2010-07-08) |
| parents | 72c5e0ee7c98 |
| children | 808269b7f41c |
| rev | line source |
|---|---|
| bsw@10 | 1 local initiative = Initiative:by_id(param.get("initiative_id")) |
| bsw@10 | 2 local initiator = Initiator:by_pk(initiative.id, app.session.member.id) |
| bsw@10 | 3 |
| bsw@10 | 4 -- TODO important m1 selectors returning result _SET_! |
| bsw@10 | 5 local issue = initiative:get_reference_selector("issue"):for_share():single_object_mode():exec() |
| bsw@10 | 6 |
| bsw@10 | 7 if issue.closed then |
| bsw@10 | 8 slot.put_into("error", _"This issue is already closed.") |
| bsw@10 | 9 return false |
| bsw@10 | 10 elseif issue.half_frozen then |
| bsw@10 | 11 slot.put_into("error", _"This issue is already frozen.") |
| bsw@10 | 12 return false |
| bsw@10 | 13 end |
| bsw@10 | 14 |
| bsw@10 | 15 if initiative.revoked then |
| bsw@10 | 16 slot.put_into("error", _"This initiative is revoked") |
| bsw@10 | 17 return false |
| bsw@10 | 18 end |
| bsw@10 | 19 |
| bsw@10 | 20 local initiator_todelete = Initiator:by_pk(initiative.id, param.get("member_id", atom.integer)) |
| bsw@10 | 21 |
| bsw@10 | 22 if not (initiator and initiator.accepted) and not (initiator.member_id == initiator_todelete.member_id) then |
| bsw@10 | 23 error("access denied") |
| bsw@10 | 24 end |
| bsw@10 | 25 |
| bsw@10 | 26 if initiator_todelete.accepted == false and initiator.member_id ~= initiator_todelete.member_id then |
| bsw@10 | 27 error("access denied") |
| bsw@10 | 28 end |
| bsw@10 | 29 |
| bsw@10 | 30 local initiators = initiative |
| bsw@10 | 31 :get_reference_selector("initiators") |
| bsw@10 | 32 :add_where("accepted") |
| bsw@10 | 33 :for_update() |
| bsw@10 | 34 :exec() |
| bsw@10 | 35 |
| bsw@10 | 36 if #initiators > 1 or initiator_todelete.accepted ~= true then |
| bsw@10 | 37 initiator_todelete:destroy() |
| bsw@10 | 38 slot.put_into("notice", _"Member has been removed from initiators") |
| bsw@10 | 39 else |
| bsw@10 | 40 slot.put_into("error", _"Can't remove last initiator") |
| bsw@10 | 41 return false |
| bsw@10 | 42 end |
| bsw@10 | 43 |
| bsw@10 | 44 |