liquid_feedback_frontend
annotate app/main/opinion/_action/update.lua @ 75:733f65c0c0a0
Bugfixes, feature enhancements, code-cleanup, and major work on API
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
| author | bsw |
|---|---|
| date | Thu Jul 08 18:44:02 2010 +0200 (2010-07-08) |
| parents | 8d91bccab0bf |
| children | 6a12fb7e4963 |
| rev | line source |
|---|---|
| bsw/jbe@0 | 1 local member_id = app.session.member.id |
| bsw/jbe@0 | 2 |
| bsw/jbe@0 | 3 local suggestion_id = param.get("suggestion_id", atom.integer) |
| bsw/jbe@0 | 4 |
| bsw/jbe@0 | 5 local opinion = Opinion:by_pk(member_id, suggestion_id) |
| bsw/jbe@0 | 6 |
| bsw/jbe@6 | 7 local suggestion = Suggestion:by_id(suggestion_id) |
| bsw/jbe@6 | 8 |
| bsw/jbe@6 | 9 if not suggestion then |
| bsw/jbe@6 | 10 slot.put_into("error", _"This suggestion has been meanwhile deleted") |
| bsw/jbe@6 | 11 return false |
| bsw/jbe@6 | 12 end |
| bsw/jbe@6 | 13 |
| bsw/jbe@5 | 14 -- TODO important m1 selectors returning result _SET_! |
| bsw/jbe@6 | 15 local issue = suggestion.initiative:get_reference_selector("issue"):for_share():single_object_mode():exec() |
| bsw/jbe@5 | 16 |
| bsw/jbe@5 | 17 if issue.closed then |
| bsw/jbe@5 | 18 slot.put_into("error", _"This issue is already closed.") |
| bsw/jbe@5 | 19 return false |
| bsw/jbe@5 | 20 elseif issue.fully_frozen then |
| bsw/jbe@5 | 21 slot.put_into("error", _"Voting for this issue has already begun.") |
| bsw/jbe@5 | 22 return false |
| bsw/jbe@5 | 23 end |
| bsw/jbe@5 | 24 |
| bsw/jbe@5 | 25 |
| bsw/jbe@5 | 26 |
| bsw@3 | 27 if param.get("delete") then |
| bsw@3 | 28 if opinion then |
| bsw@3 | 29 opinion:destroy() |
| bsw@3 | 30 end |
| bsw@3 | 31 slot.put_into("notice", _"Your opinion has been deleted") |
| bsw/jbe@0 | 32 return |
| bsw/jbe@0 | 33 end |
| bsw/jbe@0 | 34 |
| bsw/jbe@0 | 35 if not opinion then |
| bsw/jbe@0 | 36 opinion = Opinion:new() |
| bsw/jbe@0 | 37 opinion.member_id = member_id |
| bsw/jbe@0 | 38 opinion.suggestion_id = suggestion_id |
| bsw/jbe@0 | 39 opinion.fulfilled = false |
| bsw/jbe@0 | 40 end |
| bsw/jbe@0 | 41 |
| bsw/jbe@0 | 42 local degree = param.get("degree", atom.number) |
| bsw/jbe@0 | 43 local fulfilled = param.get("fulfilled", atom.boolean) |
| bsw/jbe@0 | 44 |
| bsw/jbe@0 | 45 if degree ~= nil then |
| bsw/jbe@0 | 46 opinion.degree = degree |
| bsw/jbe@0 | 47 end |
| bsw/jbe@0 | 48 |
| bsw/jbe@0 | 49 if fulfilled ~= nil then |
| bsw/jbe@0 | 50 opinion.fulfilled = fulfilled |
| bsw/jbe@0 | 51 end |
| bsw/jbe@0 | 52 |
| bsw/jbe@0 | 53 opinion:save() |
| bsw/jbe@0 | 54 |
| bsw/jbe@0 | 55 slot.put_into("notice", _"Your opinion has been updated") |