liquid_feedback_frontend
annotate app/main/suggestion/new.lua @ 75:733f65c0c0a0
Bugfixes, feature enhancements, code-cleanup, and major work on API
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
| author | bsw |
|---|---|
| date | Thu Jul 08 18:44:02 2010 +0200 (2010-07-08) |
| parents | 00d1004545f1 |
| children | 02e24b4dd21c |
| rev | line source |
|---|---|
| bsw/jbe@19 | 1 local initiative_id = param.get("initiative_id") |
| bsw/jbe@19 | 2 |
| bsw/jbe@19 | 3 slot.put_into("title", _"Add new suggestion") |
| bsw/jbe@19 | 4 |
| bsw/jbe@19 | 5 slot.select("actions", function() |
| bsw/jbe@19 | 6 ui.link{ |
| bsw/jbe@19 | 7 content = function() |
| bsw/jbe@19 | 8 ui.image{ static = "icons/16/cancel.png" } |
| bsw/jbe@19 | 9 slot.put(_"Cancel") |
| bsw/jbe@19 | 10 end, |
| bsw/jbe@19 | 11 module = "initiative", |
| bsw/jbe@19 | 12 view = "show", |
| bsw/jbe@19 | 13 id = initiative_id, |
| bsw/jbe@19 | 14 params = { tab = "suggestions" } |
| bsw/jbe@19 | 15 } |
| bsw/jbe@19 | 16 end) |
| bsw/jbe@19 | 17 |
| bsw/jbe@19 | 18 ui.form{ |
| bsw/jbe@19 | 19 module = "suggestion", |
| bsw/jbe@19 | 20 action = "add", |
| bsw/jbe@19 | 21 params = { initiative_id = initiative_id }, |
| bsw/jbe@19 | 22 routing = { |
| bsw/jbe@19 | 23 default = { |
| bsw/jbe@19 | 24 mode = "redirect", |
| bsw/jbe@19 | 25 module = "initiative", |
| bsw/jbe@19 | 26 view = "show", |
| bsw/jbe@19 | 27 id = initiative_id, |
| bsw/jbe@19 | 28 params = { tab = "suggestions" } |
| bsw/jbe@19 | 29 } |
| bsw/jbe@19 | 30 }, |
| bsw/jbe@19 | 31 attr = { class = "vertical" }, |
| bsw/jbe@19 | 32 content = function() |
| bsw/jbe@19 | 33 local supported = Supporter:by_pk(initiative_id, app.session.member.id) and true or false |
| bsw/jbe@19 | 34 if not supported then |
| bsw/jbe@19 | 35 ui.field.text{ |
| bsw/jbe@19 | 36 attr = { class = "warning" }, |
| bsw/jbe@19 | 37 value = _"You are currently not supporting this initiative. By adding suggestions to this initiative you will automatically become a potential supporter." |
| bsw/jbe@19 | 38 } |
| bsw/jbe@19 | 39 end |
| bsw/jbe@19 | 40 ui.field.text{ label = _"Title (80 chars max)", name = "name" } |
| bsw/jbe@19 | 41 ui.field.text{ label = _"Description", name = "description", multiline = true } |
| bsw/jbe@19 | 42 ui.field.select{ |
| bsw/jbe@19 | 43 label = _"Degree", |
| bsw/jbe@19 | 44 name = "degree", |
| bsw/jbe@19 | 45 foreign_records = { |
| bsw/jbe@19 | 46 { id = 1, name = _"should"}, |
| bsw/jbe@19 | 47 { id = 2, name = _"must"}, |
| bsw/jbe@19 | 48 }, |
| bsw/jbe@19 | 49 foreign_id = "id", |
| bsw/jbe@19 | 50 foreign_name = "name" |
| bsw/jbe@19 | 51 } |
| bsw/jbe@19 | 52 ui.submit{ text = _"Commit suggestion" } |
| bsw/jbe@19 | 53 end |
| bsw/jbe@19 | 54 } |