liquid_feedback_core

annotate update/core-update.v3.0.0-v3.0.1.sql @ 418:1088d83d92e8

Bugfix for battle data reconstruction in update script
author jbe
date Wed Mar 26 20:08:50 2014 +0100 (2014-03-26)
parents bc94ea65757b
children 044a2b65c707
rev   line source
jbe@416 1 BEGIN;
jbe@416 2
jbe@416 3 CREATE OR REPLACE VIEW "liquid_feedback_version" AS
jbe@416 4 SELECT * FROM (VALUES ('3.0.1', 3, 0, 1))
jbe@416 5 AS "subquery"("string", "major", "minor", "revision");
jbe@416 6
jbe@416 7 ALTER TABLE "initiative" ADD COLUMN "first_preference_votes" INT4;
jbe@416 8
jbe@416 9 ALTER TABLE "initiative" DROP CONSTRAINT "non_admitted_initiatives_cant_contain_voting_results";
jbe@416 10 ALTER TABLE "initiative" ADD CONSTRAINT "non_admitted_initiatives_cant_contain_voting_results" CHECK (
jbe@416 11 ( "admitted" NOTNULL AND "admitted" = TRUE ) OR
jbe@416 12 ( "first_preference_votes" ISNULL AND
jbe@416 13 "positive_votes" ISNULL AND "negative_votes" ISNULL AND
jbe@416 14 "direct_majority" ISNULL AND "indirect_majority" ISNULL AND
jbe@416 15 "schulze_rank" ISNULL AND
jbe@416 16 "better_than_status_quo" ISNULL AND "worse_than_status_quo" ISNULL AND
jbe@416 17 "reverse_beat_path" ISNULL AND "multistage_majority" ISNULL AND
jbe@416 18 "eligible" ISNULL AND "winner" ISNULL AND "rank" ISNULL ) );
jbe@416 19
jbe@416 20 COMMENT ON COLUMN "initiative"."first_preference_votes" IS 'Number of direct and delegating voters who ranked this initiative as their first choice';
jbe@416 21 COMMENT ON COLUMN "initiative"."positive_votes" IS 'Number of direct and delegating voters who ranked this initiative better than the status quo';
jbe@416 22 COMMENT ON COLUMN "initiative"."negative_votes" IS 'Number of direct and delegating voters who ranked this initiative worse than the status quo';
jbe@416 23
jbe@416 24 -- UPDATE TABLE "vote" SET "grade" = 0 WHERE "grade" ISNULL; -- should not be necessary
jbe@416 25 ALTER TABLE "vote" ALTER COLUMN "grade" SET NOT NULL;
jbe@416 26
jbe@416 27 ALTER TABLE "vote" ADD COLUMN "first_preference" BOOLEAN;
jbe@416 28
jbe@416 29 ALTER TABLE "vote" ADD
jbe@416 30 CONSTRAINT "first_preference_flag_only_set_on_positive_grades"
jbe@416 31 CHECK ("grade" > 0 OR "first_preference" ISNULL);
jbe@416 32
jbe@416 33 COMMENT ON COLUMN "vote"."first_preference" IS 'Value is automatically set after voting is finished. For positive grades, this value is set to true for the highest (i.e. best) grade.';
jbe@416 34
jbe@416 35 INSERT INTO "temporary_transaction_data" ("key", "value")
jbe@416 36 VALUES ('override_protection_triggers', TRUE::TEXT);
jbe@416 37
jbe@416 38 UPDATE "vote" SET "first_preference" = "subquery"."first_preference"
jbe@416 39 FROM (
jbe@416 40 SELECT
jbe@416 41 "vote"."initiative_id",
jbe@416 42 "vote"."member_id",
jbe@416 43 CASE WHEN "vote"."grade" > 0 THEN
jbe@416 44 CASE WHEN "vote"."grade" = max("agg"."grade") THEN TRUE ELSE FALSE END
jbe@416 45 ELSE NULL
jbe@416 46 END AS "first_preference"
jbe@416 47 FROM "vote"
jbe@416 48 JOIN "initiative" -- NOTE: due to missing index on issue_id
jbe@416 49 ON "vote"."issue_id" = "initiative"."issue_id"
jbe@416 50 JOIN "vote" AS "agg"
jbe@416 51 ON "initiative"."id" = "agg"."initiative_id"
jbe@416 52 AND "vote"."member_id" = "agg"."member_id"
jbe@416 53 GROUP BY "vote"."initiative_id", "vote"."member_id"
jbe@416 54 ) AS "subquery"
jbe@416 55 WHERE "vote"."initiative_id" = "subquery"."initiative_id"
jbe@416 56 AND "vote"."member_id" = "subquery"."member_id";
jbe@416 57
jbe@416 58 DELETE FROM "temporary_transaction_data"
jbe@416 59 WHERE "key" = 'override_protection_triggers';
jbe@416 60
jbe@416 61 UPDATE "initiative"
jbe@416 62 SET "first_preference_votes" = coalesce("subquery"."sum", 0)
jbe@416 63 FROM (
jbe@416 64 SELECT "vote"."initiative_id", sum("direct_voter"."weight")
jbe@416 65 FROM "vote" JOIN "direct_voter"
jbe@416 66 ON "vote"."issue_id" = "direct_voter"."issue_id"
jbe@416 67 AND "vote"."member_id" = "direct_voter"."member_id"
jbe@416 68 WHERE "vote"."first_preference"
jbe@416 69 GROUP BY "vote"."initiative_id"
jbe@416 70 ) AS "subquery"
jbe@416 71 WHERE "initiative"."admitted"
jbe@416 72 AND "initiative"."id" = "subquery"."initiative_id";
jbe@416 73
jbe@418 74 -- reconstruct battle data (originating from LiquidFeedback Core before v2.0.0)
jbe@418 75 -- to avoid future data loss when executing "clean_issue" to delete voting data:
jbe@417 76 INSERT INTO "battle" (
jbe@417 77 "issue_id",
jbe@417 78 "winning_initiative_id",
jbe@417 79 "losing_initiative_id",
jbe@417 80 "count"
jbe@417 81 ) SELECT
jbe@417 82 "battle_view"."issue_id",
jbe@417 83 "battle_view"."winning_initiative_id",
jbe@417 84 "battle_view"."losing_initiative_id",
jbe@417 85 "battle_view"."count"
jbe@418 86 FROM (
jbe@418 87 SELECT
jbe@418 88 "issue"."id" AS "issue_id",
jbe@418 89 "winning_initiative"."id" AS "winning_initiative_id",
jbe@418 90 "losing_initiative"."id" AS "losing_initiative_id",
jbe@418 91 sum(
jbe@418 92 CASE WHEN
jbe@418 93 coalesce("better_vote"."grade", 0) >
jbe@418 94 coalesce("worse_vote"."grade", 0)
jbe@418 95 THEN "direct_voter"."weight" ELSE 0 END
jbe@418 96 ) AS "count"
jbe@418 97 FROM "issue"
jbe@418 98 LEFT JOIN "direct_voter"
jbe@418 99 ON "issue"."id" = "direct_voter"."issue_id"
jbe@418 100 JOIN "battle_participant" AS "winning_initiative"
jbe@418 101 ON "issue"."id" = "winning_initiative"."issue_id"
jbe@418 102 JOIN "battle_participant" AS "losing_initiative"
jbe@418 103 ON "issue"."id" = "losing_initiative"."issue_id"
jbe@418 104 LEFT JOIN "vote" AS "better_vote"
jbe@418 105 ON "direct_voter"."member_id" = "better_vote"."member_id"
jbe@418 106 AND "winning_initiative"."id" = "better_vote"."initiative_id"
jbe@418 107 LEFT JOIN "vote" AS "worse_vote"
jbe@418 108 ON "direct_voter"."member_id" = "worse_vote"."member_id"
jbe@418 109 AND "losing_initiative"."id" = "worse_vote"."initiative_id"
jbe@418 110 WHERE "issue"."state" IN ('finished_with_winner', 'finished_without_winner')
jbe@418 111 AND "winning_initiative"."id" != "losing_initiative"."id"
jbe@418 112 -- NOTE: comparisons with status-quo are intentionally omitted to mark
jbe@418 113 -- issues that were counted prior LiquidFeedback Core v2.0.0
jbe@418 114 GROUP BY
jbe@418 115 "issue"."id",
jbe@418 116 "winning_initiative"."id",
jbe@418 117 "losing_initiative"."id"
jbe@418 118 ) AS "battle_view"
jbe@417 119 LEFT JOIN "battle"
jbe@417 120 ON "battle_view"."winning_initiative_id" = "battle"."winning_initiative_id"
jbe@417 121 AND "battle_view"."losing_initiative_id" = "battle"."losing_initiative_id"
jbe@417 122 WHERE "battle" ISNULL;
jbe@417 123
jbe@416 124 CREATE OR REPLACE FUNCTION "close_voting"("issue_id_p" "issue"."id"%TYPE)
jbe@416 125 RETURNS VOID
jbe@416 126 LANGUAGE 'plpgsql' VOLATILE AS $$
jbe@416 127 DECLARE
jbe@416 128 "area_id_v" "area"."id"%TYPE;
jbe@416 129 "unit_id_v" "unit"."id"%TYPE;
jbe@416 130 "member_id_v" "member"."id"%TYPE;
jbe@416 131 BEGIN
jbe@416 132 PERFORM "require_transaction_isolation"();
jbe@416 133 SELECT "area_id" INTO "area_id_v" FROM "issue" WHERE "id" = "issue_id_p";
jbe@416 134 SELECT "unit_id" INTO "unit_id_v" FROM "area" WHERE "id" = "area_id_v";
jbe@416 135 -- override protection triggers:
jbe@416 136 INSERT INTO "temporary_transaction_data" ("key", "value")
jbe@416 137 VALUES ('override_protection_triggers', TRUE::TEXT);
jbe@416 138 -- delete timestamp of voting comment:
jbe@416 139 UPDATE "direct_voter" SET "comment_changed" = NULL
jbe@416 140 WHERE "issue_id" = "issue_id_p";
jbe@416 141 -- delete delegating votes (in cases of manual reset of issue state):
jbe@416 142 DELETE FROM "delegating_voter"
jbe@416 143 WHERE "issue_id" = "issue_id_p";
jbe@416 144 -- delete votes from non-privileged voters:
jbe@416 145 DELETE FROM "direct_voter"
jbe@416 146 USING (
jbe@416 147 SELECT
jbe@416 148 "direct_voter"."member_id"
jbe@416 149 FROM "direct_voter"
jbe@416 150 JOIN "member" ON "direct_voter"."member_id" = "member"."id"
jbe@416 151 LEFT JOIN "privilege"
jbe@416 152 ON "privilege"."unit_id" = "unit_id_v"
jbe@416 153 AND "privilege"."member_id" = "direct_voter"."member_id"
jbe@416 154 WHERE "direct_voter"."issue_id" = "issue_id_p" AND (
jbe@416 155 "member"."active" = FALSE OR
jbe@416 156 "privilege"."voting_right" ISNULL OR
jbe@416 157 "privilege"."voting_right" = FALSE
jbe@416 158 )
jbe@416 159 ) AS "subquery"
jbe@416 160 WHERE "direct_voter"."issue_id" = "issue_id_p"
jbe@416 161 AND "direct_voter"."member_id" = "subquery"."member_id";
jbe@416 162 -- consider delegations:
jbe@416 163 UPDATE "direct_voter" SET "weight" = 1
jbe@416 164 WHERE "issue_id" = "issue_id_p";
jbe@416 165 PERFORM "add_vote_delegations"("issue_id_p");
jbe@416 166 -- mark first preferences:
jbe@416 167 UPDATE "vote" SET "first_preference" = "subquery"."first_preference"
jbe@416 168 FROM (
jbe@416 169 SELECT
jbe@416 170 "vote"."initiative_id",
jbe@416 171 "vote"."member_id",
jbe@416 172 CASE WHEN "vote"."grade" > 0 THEN
jbe@416 173 CASE WHEN "vote"."grade" = max("agg"."grade") THEN TRUE ELSE FALSE END
jbe@416 174 ELSE NULL
jbe@416 175 END AS "first_preference"
jbe@416 176 FROM "vote"
jbe@416 177 JOIN "initiative" -- NOTE: due to missing index on issue_id
jbe@416 178 ON "vote"."issue_id" = "initiative"."issue_id"
jbe@416 179 JOIN "vote" AS "agg"
jbe@416 180 ON "initiative"."id" = "agg"."initiative_id"
jbe@416 181 AND "vote"."member_id" = "agg"."member_id"
jbe@416 182 GROUP BY "vote"."initiative_id", "vote"."member_id"
jbe@416 183 ) AS "subquery"
jbe@416 184 WHERE "vote"."issue_id" = "issue_id_p"
jbe@416 185 AND "vote"."initiative_id" = "subquery"."initiative_id"
jbe@416 186 AND "vote"."member_id" = "subquery"."member_id";
jbe@416 187 -- finish overriding protection triggers (avoids garbage):
jbe@416 188 DELETE FROM "temporary_transaction_data"
jbe@416 189 WHERE "key" = 'override_protection_triggers';
jbe@416 190 -- materialize battle_view:
jbe@416 191 -- NOTE: "closed" column of issue must be set at this point
jbe@416 192 DELETE FROM "battle" WHERE "issue_id" = "issue_id_p";
jbe@416 193 INSERT INTO "battle" (
jbe@416 194 "issue_id",
jbe@416 195 "winning_initiative_id", "losing_initiative_id",
jbe@416 196 "count"
jbe@416 197 ) SELECT
jbe@416 198 "issue_id",
jbe@416 199 "winning_initiative_id", "losing_initiative_id",
jbe@416 200 "count"
jbe@416 201 FROM "battle_view" WHERE "issue_id" = "issue_id_p";
jbe@416 202 -- set voter count:
jbe@416 203 UPDATE "issue" SET
jbe@416 204 "voter_count" = (
jbe@416 205 SELECT coalesce(sum("weight"), 0)
jbe@416 206 FROM "direct_voter" WHERE "issue_id" = "issue_id_p"
jbe@416 207 )
jbe@416 208 WHERE "id" = "issue_id_p";
jbe@416 209 -- calculate "first_preference_votes":
jbe@416 210 UPDATE "initiative"
jbe@416 211 SET "first_preference_votes" = coalesce("subquery"."sum", 0)
jbe@416 212 FROM (
jbe@416 213 SELECT "vote"."initiative_id", sum("direct_voter"."weight")
jbe@416 214 FROM "vote" JOIN "direct_voter"
jbe@416 215 ON "vote"."issue_id" = "direct_voter"."issue_id"
jbe@416 216 AND "vote"."member_id" = "direct_voter"."member_id"
jbe@416 217 WHERE "vote"."first_preference"
jbe@416 218 GROUP BY "vote"."initiative_id"
jbe@416 219 ) AS "subquery"
jbe@416 220 WHERE "initiative"."issue_id" = "issue_id_p"
jbe@416 221 AND "initiative"."admitted"
jbe@416 222 AND "initiative"."id" = "subquery"."initiative_id";
jbe@416 223 -- copy "positive_votes" and "negative_votes" from "battle" table:
jbe@416 224 UPDATE "initiative" SET
jbe@416 225 "positive_votes" = "battle_win"."count",
jbe@416 226 "negative_votes" = "battle_lose"."count"
jbe@416 227 FROM "battle" AS "battle_win", "battle" AS "battle_lose"
jbe@416 228 WHERE
jbe@416 229 "battle_win"."issue_id" = "issue_id_p" AND
jbe@416 230 "battle_win"."winning_initiative_id" = "initiative"."id" AND
jbe@416 231 "battle_win"."losing_initiative_id" ISNULL AND
jbe@416 232 "battle_lose"."issue_id" = "issue_id_p" AND
jbe@416 233 "battle_lose"."losing_initiative_id" = "initiative"."id" AND
jbe@416 234 "battle_lose"."winning_initiative_id" ISNULL;
jbe@416 235 END;
jbe@416 236 $$;
jbe@416 237
jbe@416 238 COMMIT;

Impressum / About Us