liquid_feedback_frontend
annotate app/main/initiative/_action/add_initiator.lua @ 75:733f65c0c0a0
Bugfixes, feature enhancements, code-cleanup, and major work on API
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
| author | bsw |
|---|---|
| date | Thu Jul 08 18:44:02 2010 +0200 (2010-07-08) |
| parents | 72c5e0ee7c98 |
| children | 808269b7f41c |
| rev | line source |
|---|---|
| bsw@10 | 1 local initiative = Initiative:by_id(param.get("initiative_id")) |
| bsw@10 | 2 local member = Member:by_id(param.get("member_id")) |
| bsw@10 | 3 |
| bsw@10 | 4 if not member then |
| bsw@10 | 5 slot.put_into("error", _"Please choose a member") |
| bsw@10 | 6 return false |
| bsw@10 | 7 end |
| bsw@10 | 8 |
| bsw@10 | 9 local initiator = Initiator:by_pk(initiative.id, app.session.member.id) |
| bsw@10 | 10 if not initiator or initiator.accepted ~= true then |
| bsw@10 | 11 error("access denied") |
| bsw@10 | 12 end |
| bsw@10 | 13 |
| bsw@10 | 14 -- TODO important m1 selectors returning result _SET_! |
| bsw@10 | 15 local issue = initiative:get_reference_selector("issue"):for_share():single_object_mode():exec() |
| bsw@10 | 16 |
| bsw@10 | 17 if issue.closed then |
| bsw@10 | 18 slot.put_into("error", _"This issue is already closed.") |
| bsw@10 | 19 return false |
| bsw@10 | 20 elseif issue.half_frozen then |
| bsw@10 | 21 slot.put_into("error", _"This issue is already frozen.") |
| bsw@10 | 22 return false |
| bsw@10 | 23 end |
| bsw@10 | 24 |
| bsw@10 | 25 if initiative.revoked then |
| bsw@10 | 26 slot.put_into("error", _"This initiative is revoked") |
| bsw@10 | 27 return false |
| bsw@10 | 28 end |
| bsw@10 | 29 |
| bsw@10 | 30 local initiator = Initiator:by_pk(initiative.id, member.id) |
| bsw@10 | 31 if initiator then |
| bsw@10 | 32 if initiator.accepted == true then |
| bsw@10 | 33 slot.put_into("error", _"This member is already initiator of this initiative") |
| bsw@10 | 34 elseif initiator.accepted == false then |
| bsw@10 | 35 slot.put_into("error", _"This member has rejected to become initiator of this initiative") |
| bsw@10 | 36 elseif initiator.accepted == nil then |
| bsw@10 | 37 slot.put_into("error", _"This member is already invited to become initiator of this initiative") |
| bsw@10 | 38 end |
| bsw@10 | 39 return false |
| bsw@10 | 40 end |
| bsw@10 | 41 |
| bsw@10 | 42 local initiator = Initiator:new() |
| bsw@10 | 43 initiator.initiative_id = initiative.id |
| bsw@10 | 44 initiator.member_id = member.id |
| bsw@10 | 45 initiator.accepted = nil |
| bsw@10 | 46 initiator:save() |
| bsw@10 | 47 |
| bsw@10 | 48 slot.put_into("notice", _"Member is now invited to be initiator") |
| bsw@10 | 49 |