liquid_feedback_frontend
view app/main/initiative/_action/add_initiator.lua @ 75:733f65c0c0a0
Bugfixes, feature enhancements, code-cleanup, and major work on API
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
Details:
- API
-- Allow relation name to be passed to helper function util.autoapi{...}
-- Added area API
-- Bugfixes in API
--- Correctly return initiatives (bug #162)
--- Correctly process "id" parameter for initiative API
--- Bugfix related to "state" parameter (bug #165)
--- Changed constant "discussion" to "accepted" (in model/issue.lua, used by API)
--- Fixed JSON encoding in auto_api (bug #181)
--- Ignore list filter "voted" in case of public access
--- Enable access to API without session
- Work on RSS feed (incomplete yet)
- Other bugfixes
-- Handle empty browser identification string
-- Handle invalid date in member/update.lua (bugs #24 #109 #115 #136)
-- Better handle errors while converting uploaded images. (bug #79 +5 duplicates)
-- Don't display revoked initiatives in list of new drafts (bug #134)
-- Fixed syntax error in app/main/member/_action/update_name.lua throwing unexpected error, when new name was too short
-- Do not display refresh support button for revoked initiatives
-- Repaired issue search (bug #150)
-- Fixed typos in german translation files
--- "initi(i)erte"
--- "Er(g)eignisse" (bug #161)
- Code cleanup
-- Removed deprecated motd files locale/motd/de.txt and locale/motd/de_public.txt
-- Removed redundant code in app/main/index/_updated_drafts.lua
- New features and (optical) enhancements
-- Support change of notify email; notification of not approved address added to start page
-- Settings dialog splitted into single pages
-- Mark deactivated members
-- Calendar for birthday selection in profile
-- Policy list public readable when public access is enabled
| author | bsw |
|---|---|
| date | Thu Jul 08 18:44:02 2010 +0200 (2010-07-08) |
| parents | 72c5e0ee7c98 |
| children | 808269b7f41c |
line source
1 local initiative = Initiative:by_id(param.get("initiative_id"))
2 local member = Member:by_id(param.get("member_id"))
4 if not member then
5 slot.put_into("error", _"Please choose a member")
6 return false
7 end
9 local initiator = Initiator:by_pk(initiative.id, app.session.member.id)
10 if not initiator or initiator.accepted ~= true then
11 error("access denied")
12 end
14 -- TODO important m1 selectors returning result _SET_!
15 local issue = initiative:get_reference_selector("issue"):for_share():single_object_mode():exec()
17 if issue.closed then
18 slot.put_into("error", _"This issue is already closed.")
19 return false
20 elseif issue.half_frozen then
21 slot.put_into("error", _"This issue is already frozen.")
22 return false
23 end
25 if initiative.revoked then
26 slot.put_into("error", _"This initiative is revoked")
27 return false
28 end
30 local initiator = Initiator:by_pk(initiative.id, member.id)
31 if initiator then
32 if initiator.accepted == true then
33 slot.put_into("error", _"This member is already initiator of this initiative")
34 elseif initiator.accepted == false then
35 slot.put_into("error", _"This member has rejected to become initiator of this initiative")
36 elseif initiator.accepted == nil then
37 slot.put_into("error", _"This member is already invited to become initiator of this initiative")
38 end
39 return false
40 end
42 local initiator = Initiator:new()
43 initiator.initiative_id = initiative.id
44 initiator.member_id = member.id
45 initiator.accepted = nil
46 initiator:save()
48 slot.put_into("notice", _"Member is now invited to be initiator")